Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename LLMonitor Callback Handler #14721

Closed
wants to merge 28 commits into from
Closed

Rename LLMonitor Callback Handler #14721

wants to merge 28 commits into from

Conversation

hughcrt
Copy link
Contributor

@hughcrt hughcrt commented Dec 14, 2023

Following #14574, I've added LunaryCallbackHandler in langchain_community and kept LLMonitorCallbackHandler as an alias, in order to ensure backward compability.
Thanks!

@hwchase17

@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 1:30pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: models Related to LLMs or chat model modules 🤖:refactor A large refactor of a feature(s) or restructuring of many files labels Dec 14, 2023
@hughcrt
Copy link
Contributor Author

hughcrt commented Dec 19, 2023

Hi @hwchase17, could you please check and confirm if the pull request can now be merged?

@vincelwt
Copy link
Contributor

Hi @baskaryan pinging you also to see if there is something else to do to get this merged :) Thanks

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Dec 26, 2023
hwchase17
hwchase17 reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments just to make sure we dont update langchain, otherwise lgtm

@hughcrt
Copy link
Contributor Author

hughcrt commented Jan 2, 2024

Hi @hwchase17, I've made the changes you've suggested

@hwchase17
Copy link
Contributor

hmm seems like some merge conflicts that need to be resolve via command line?

@hughcrt
Copy link
Contributor Author

hughcrt commented Jan 4, 2024

Hi @hwchase17, I've resolved the conflicts.

@efriis efriis self-assigned this Jan 8, 2024
@efriis
Copy link
Member

efriis commented Jan 29, 2024

Changes a bunch of unrelated files (including CI) - feel free to clean up and reopen!

@efriis efriis closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 left review comments

Assignees

@efriis efriis

Labels
Ɑ: models Related to LLMs or chat model modules partner 🤖:refactor A large refactor of a feature(s) or restructuring of many files size:L This PR changes 100-499 lines, ignoring generated files. template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hughcrt @vincelwt @hwchase17 @efriis