Fixes to SelfQueryRetriever and LLMRouterChain deprecation warning #10617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recated `predict_and_parse` method
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: models
RoderickVM
changed the title
RoderickVM
changed the title
efriis
reviewed
Nov 30, 2023
| ) | ||
| if self.llm_chain.prompt.output_parser is not None: | ||
| output = self.llm_chain.prompt.output_parser.parse(output) |
There was a problem hiding this comment.
the goal of deprecating predict_and_parse is actually to avoid storing the output parser on the prompt. Instead, can you update to store on the llm_chain instead?
|
Apologies for the slow review! Pr has some merge conflicts, happy to re-review if you'd like to resolve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_get_relevant_documentsfunction insideSelfQueryRetrieverand_callfunction insideLLMRouterChainto avoid using the deprecatedpredict_and_parsefunction insideLLMChain, and not getting the (annoying) warning message.SelfQueryRetriever, and LLMRouterChain uses deprecated predict_and_parse method #6819 forLLMRouterChainPS : This is my first PR ever, and I am far from being a pro Dev. So your feedback, comments and guidance are more than welcome!