Skip to content

Commit

Permalink
infra: specify python max version of 3.12 for some integration packag…
Browse files Browse the repository at this point in the history
…es (#27740)
  • Loading branch information
ccurme authored Oct 30, 2024
1 parent 3b956b3 commit 88bfd60
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
19 changes: 16 additions & 3 deletions .github/scripts/check_diff.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,21 @@
"huggingface",
]

# Cap python version at 3.12 for some packages with dependencies that are not yet
# compatible with python 3.13 (mostly hf tokenizers).
PY_312_MAX_PACKAGES = [
f"libs/partners/{integration}"
for integration in [
"anthropic",
"chroma",
"couchbase",
"huggingface",
"mistralai",
"nomic",
"qdrant",
]
]


def all_package_dirs() -> Set[str]:
return {
Expand Down Expand Up @@ -117,9 +132,7 @@ def _get_configs_for_single_dir(job: str, dir_: str) -> List[Dict[str, str]]:
# declare deps in funny way
py_versions = ["3.9", "3.11"]

elif dir_ == "libs/partners/huggingface":
# huggingface tokenizers doesn't support 3.13 yet
# because of pep517 builds
elif dir_ in PY_312_MAX_PACKAGES:
py_versions = ["3.9", "3.12"]

elif dir_ in ["libs/community", "libs/langchain"] and job == "extended-tests":
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def test__convert_dict_to_message_tool_call() -> None:
InvalidToolCall(
name="GenerateUsername",
args="oops",
error="Function GenerateUsername arguments:\n\noops\n\nare not valid JSON. Received JSONDecodeError Expecting value: line 1 column 1 (char 0)", # noqa: E501
error="Function GenerateUsername arguments:\n\noops\n\nare not valid JSON. Received JSONDecodeError Expecting value: line 1 column 1 (char 0)\nFor troubleshooting, visit: https://python.langchain.com/docs/troubleshooting/errors/OUTPUT_PARSING_FAILURE", # noqa: E501
id="ssAbar4Dr",
type="invalid_tool_call",
),
Expand Down

0 comments on commit 88bfd60

Please sign in to comment.