Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error when vector and query are None #142

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Throw error when vector and query are None #142

merged 2 commits into from
Mar 25, 2024

Conversation

hsm207
Copy link
Collaborator

@hsm207 hsm207 commented Mar 25, 2024 •
edited
Loading

These are okay:

weaviate_vector_store._perform_search(query="hello", vector=None, k=5)

weaviate_vector_store._perform_search(query=None, vector=[1, 2, 3], k=5)

These are not okay:

weaviate_vector_store._perform_search(query=None, k=5)
weaviate_vector_store._perform_search(query=None, vector=None, k=5)

Signed-off-by: hsm207 [email protected]

@hsm207 hsm207 added the enhancement New feature or request label Mar 25, 2024
@hsm207 hsm207 enabled auto-merge (squash) March 25, 2024 16:23
@hsm207 hsm207 merged commit 52474ed into main Mar 25, 2024
6 checks passed
@hsm207 hsm207 deleted the invalid_search_params branch March 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hsm207