Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ai-endpoints[patch]: permit 'Bad Request' error message in integration tests #91

Closed
wants to merge 1 commit into from

Conversation

ccurme
Copy link
Contributor

@ccurme ccurme commented Aug 22, 2024

In addition to error codes, integration tests check for expected strings in the error message. These checks have been failing for the past three days. Here we update the checks to accommodate the new language.

Some alternatives:

  • Relax these tests and just check the error code;
  • Add logic inside the library to catch the errors and raise a desired error message.

@ccurme
Copy link
Contributor Author

ccurme commented Aug 22, 2024

@ccurme ccurme requested a review from mattf August 22, 2024 13:48
@mattf
Copy link
Collaborator

mattf commented Aug 23, 2024

@ccurme thank you for keeping an eye out. this is caused by a regression on the server side. give me a few days to see if i can get it resolved.

@mattf
Copy link
Collaborator

mattf commented Sep 19, 2024

@ccurme thank you for watching this. the server side has been fixed and i'm going to keep the tests as a check against server side changes.

@mattf mattf closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants