remove broken stop word detection, rely on server side implementation #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raspawar
requested changes
Jul 2, 2024
mattf
force-pushed
the
mattf/remove-stop-word-detection
branch
from
e17aa91 to
9696e9d
Compare
@raspawar ptal. i removed extraneous stop params. the is_stopped is used in streaming. |
mattf
force-pushed
the
mattf/remove-stop-word-detection
branch
from
9696e9d to
f0c0b48
Compare
raspawar
reviewed
Jul 9, 2024
| msg, is_stopped = self._aggregate_msgs(msg_list) | ||
| msg, is_stopped = self._early_stop_msg(msg, is_stopped, stop=stop) | ||
| return msg, is_stopped | ||
| return self._aggregate_msgs(self._process_response(response)) |
There was a problem hiding this comment.
is this logic needed in _aggredate_msgs?
is_stopped = msg.get("finish_reason", "") == "stop"
There was a problem hiding this comment.
it's used in stream processing
raspawar
approved these changes
Jul 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the client side stop word detection and rely on server side implementation
two issues with client side implementation -
find(...) + 1)this simplifies the output post-processing, which moves us toward using standard post-processing tools.