Provide default model in local NIM mode #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattf
reviewed
Jun 11, 2024
| # set default model | ||
| name = values.get("client").default_model.id | ||
| values["model"] = name | ||
| warnings.warn( |
There was a problem hiding this comment.
good that you're notifying the user about the action you're taking on their behalf.
mattf
reviewed
Jun 24, 2024
raspawar
force-pushed
the
raspawar/default-llm-model
branch
from
8929e9d to
834843e
Compare
mattf
reviewed
Jun 25, 2024
raspawar
force-pushed
the
raspawar/default-llm-model
branch
2 times, most recently
from
4eb3d46 to
d553c9d
Compare
mattf
reviewed
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New implementation:
This can be simplified by using the first available model if none is provided, e.g.
llm = ChatNVIDIA(base_url="http://localhost:1234/v1")
llm.chat(...)
llm._client.model => default model => first available model in local NIM
Fixes: