-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NVIDIARerank connector, a BaseDocumentCompressor, with support for NVIDIA API Catalog #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattf
force-pushed
the
mattf/add-reranking-api-catalog
branch
from
April 17, 2024 15:30
5586cde
to
6662c10
Compare
…://host:port without path
current: {"model": "...", "query": {"text": "hello world?"}, "passages": [ {"text": "passage one"}, {"text": "passage two"}, {"text": "passage three"} ], "logits": True } -> [{"index": 1, "score": 1.0, "logit": 1.234}, {"index": 2, "score": 0.5, "logit": 0.910}, {"index": 0, "score": 0.0, "logit": -5.678}] change: - remove logit option - return logits instead of normalized scores new: {"model": "...", "query": {"text": "hello world?"}, "passages": [ {"text": "passage one"}, {"text": "passage two"}, {"text": "passage three"} ] } -> [{"index": 1, "logit": 1.234}, {"index": 2, "logit": 0.910}, {"index": 0, "logit": -5.678}] user impact: - user must perform their own normalization, if desired - no impact: results are still returned in sorted order - no impact: users can still produce a total order across batches
…r NVIDIA API Catalog
doing so would require selection of a bogus logit, which will break the ability of a user to call compress_documents with disjoint sets of documents and reconstruct an ordering. at least in the degenerate case of 1 document per batch.
mattf
force-pushed
the
mattf/add-reranking-api-catalog
branch
from
April 20, 2024 12:33
6662c10
to
d95fd5a
Compare
Looks good @mattf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce NVIDIARerank, a BaseDocumentCompressor, supporting NVIDIA API Catalog, e.g.