Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTPYTHON-377 langgraph-checkpoint-mongodb #7

Conversation

caseyclements
Copy link
Collaborator

2nd package in this repo: langgraph-checkpoint-mongodb

Implements two new graph checkpointers for MongoDB. One synchronous and one asynchronous.
This closely follows the other implementations in checkpoint, checkpoint-postgres, checkpoint-sqlite but with NoSQL idioms.

This is work that was originally in a pull-request directly to langgraph (#2089)

In the review of #2089, we were told that there were additional tests that truly verified the checkpointers, this file for sync and this file for async. This PR will be marled draft until these are all green.

@caseyclements caseyclements changed the title INTPYTHON-377 Checkpointer INTPYTHON-377 langgraph-checkpoint-mongodb Nov 1, 2024
@caseyclements caseyclements marked this pull request as ready for review November 4, 2024 01:54
Copy link

@vbarda vbarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! for final version we'd need to remove the pregel test files. will let you know once standard test lib is ready :)

@vbarda
Copy link

vbarda commented Nov 21, 2024

Looks good to me! for final version we'd need to remove the pregel test files. will let you know once standard test lib is ready :)

Discussed offline -- we can merge as is and rip those tests out as soon as standard tests lib is published

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caseyclements caseyclements merged commit 21c0680 into langchain-ai:main Nov 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants