Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTPYTHON-447 Ensure index is ready for retriever tests #25

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

blink1073
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

while True:
if (time() - t0) > TIMEOUT:
raise TimeoutError(f'Search index {SEARCH_INDEX_NAME} did not complete in {TIMEOUT}')
results = collection.aggregate([{ "$search": search_content }])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. The full-text equivalent to what we do with $vectorSearch. Nice.

@blink1073 blink1073 merged commit 2f5f1fc into langchain-ai:main Dec 6, 2024
9 checks passed
@blink1073 blink1073 deleted the INTPYTHON-447 branch December 6, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants