Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add pytest flags #38

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

svidiella
Copy link
Contributor

Add support for flags on pytest and use --release flag for integration tests

Support of:

  • pytest --release
  • pytest --gpu
  • pytest --extended
  • pytest --long

Flags can be combined, and a single test can be marked with several flags.
If no flags are provided, the test will be always executed.
If marked with a flag (e.g. @pytest.mark.release) the test will only be executed if the flag is specified in the pytest call.

Marked all currently not skipped integration tests as release.
Marked test_llms_safety tests as extended (as they can be run normally in local, no extra CI setup seems to be needed).

@svidiella svidiella force-pushed the tests/add-pytest-flags branch 2 times, most recently from 1b62d88 to ca759c5 Compare February 27, 2024 16:31
@svidiella svidiella force-pushed the tests/add-pytest-flags branch from 1ba4216 to 1e7176a Compare February 28, 2024 10:25
@holtskinner holtskinner requested a review from lkuligin February 28, 2024 15:40
@lkuligin
Copy link
Collaborator

@movsic take a look, please

@lkuligin
Copy link
Collaborator

@efriis fyi, maybe you'll find the approach useful for the core repo

@lkuligin lkuligin merged commit 75d0d8c into langchain-ai:main Feb 28, 2024
12 checks passed
@svidiella svidiella deleted the tests/add-pytest-flags branch February 29, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants