Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cost callback #18

Merged
merged 2 commits into from
Feb 21, 2024
Merged

added cost callback #18

merged 2 commits into from
Feb 21, 2024

Conversation

lkuligin
Copy link
Collaborator

No description provided.

c,
self._is_gemini_model,
usage_metadata=response.to_dict().get("usage_metadata"),
),
)
for c in response.candidates
]
Copy link
Contributor

@jzaldi jzaldi Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultra nit: c, r -> candidate to make it clearer? (In general)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@jzaldi jzaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a nit

@lkuligin lkuligin merged commit 302f264 into main Feb 21, 2024
12 checks passed
@lkuligin lkuligin deleted the cost_cb branch February 21, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants