Fix no args function call #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jzaldi
commented
Feb 19, 2024
jzaldi
commented
- Fixed Key Error 'required' when defining a tool with no arguments.
- Added unit test for function utils
lkuligin
reviewed
Feb 20, 2024
| @@ -54,7 +54,7 @@ def _format_tool_to_vertex_function(tool: BaseTool) -> FunctionDescription: | |||
| } | |||
| for k, v in schema["properties"].items() | |||
| }, | |||
| "required": schema["required"], | |||
| "required": schema.get("required", []), | |||
There was a problem hiding this comment.
nits: should we maybe just remove requried arg if it's empty? it looks like it's not a required one
lkuligin
reviewed
Feb 20, 2024
| @@ -54,7 +54,7 @@ def _format_tool_to_vertex_function(tool: BaseTool) -> FunctionDescription: | |||
| } | |||
| for k, v in schema["properties"].items() | |||
| }, | |||
| "required": schema["required"], | |||
| "required": schema.get("required", []), | |||
There was a problem hiding this comment.
should we update line #34 too?
There was a problem hiding this comment.
Wraped both blocks into a function, as it was duplicated code and make it so that if there is no required there's no key
lkuligin
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.