-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release pipeline #13
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
import sys | ||
|
||
import tomllib | ||
from packaging.version import parse as parse_version | ||
import re | ||
|
||
MIN_VERSION_LIBS = ["langchain-core"] | ||
|
||
|
||
def get_min_version(version: str) -> str: | ||
# case ^x.x.x | ||
_match = re.match(r"^\^(\d+(?:\.\d+){0,2})$", version) | ||
if _match: | ||
return _match.group(1) | ||
|
||
# case >=x.x.x,<y.y.y | ||
_match = re.match(r"^>=(\d+(?:\.\d+){0,2}),<(\d+(?:\.\d+){0,2})$", version) | ||
if _match: | ||
_min = _match.group(1) | ||
_max = _match.group(2) | ||
assert parse_version(_min) < parse_version(_max) | ||
return _min | ||
|
||
# case x.x.x | ||
_match = re.match(r"^(\d+(?:\.\d+){0,2})$", version) | ||
if _match: | ||
return _match.group(1) | ||
|
||
raise ValueError(f"Unrecognized version format: {version}") | ||
|
||
|
||
def get_min_version_from_toml(toml_path: str): | ||
# Parse the TOML file | ||
with open(toml_path, "rb") as file: | ||
toml_data = tomllib.load(file) | ||
|
||
# Get the dependencies from tool.poetry.dependencies | ||
dependencies = toml_data["tool"]["poetry"]["dependencies"] | ||
|
||
# Initialize a dictionary to store the minimum versions | ||
min_versions = {} | ||
|
||
# Iterate over the libs in MIN_VERSION_LIBS | ||
for lib in MIN_VERSION_LIBS: | ||
# Check if the lib is present in the dependencies | ||
if lib in dependencies: | ||
# Get the version string | ||
version_string = dependencies[lib] | ||
|
||
# Use parse_version to get the minimum supported version from version_string | ||
min_version = get_min_version(version_string) | ||
|
||
# Store the minimum version in the min_versions dictionary | ||
min_versions[lib] = min_version | ||
|
||
return min_versions | ||
|
||
|
||
# Get the TOML file path from the command line argument | ||
toml_file = sys.argv[1] | ||
|
||
# Call the function to get the minimum versions | ||
min_versions = get_min_version_from_toml(toml_file) | ||
|
||
print(" ".join([f"{lib}=={version}" for lib, version in min_versions.items()])) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,271 @@ | ||
name: release | ||
run-name: Release ${{ inputs.working-directory }} by @${{ github.actor }} | ||
on: | ||
workflow_call: | ||
inputs: | ||
working-directory: | ||
required: true | ||
type: string | ||
description: "From which folder this pipeline executes" | ||
workflow_dispatch: | ||
inputs: | ||
working-directory: | ||
required: true | ||
type: string | ||
default: 'libs/vertexai' | ||
|
||
env: | ||
PYTHON_VERSION: "3.11" | ||
POETRY_VERSION: "1.7.1" | ||
|
||
jobs: | ||
build: | ||
if: github.ref == 'refs/heads/master' | ||
environment: Scheduled testing | ||
runs-on: ubuntu-latest | ||
|
||
outputs: | ||
pkg-name: ${{ steps.check-version.outputs.pkg-name }} | ||
version: ${{ steps.check-version.outputs.version }} | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Python + Poetry ${{ env.POETRY_VERSION }} | ||
uses: "./.github/actions/poetry_setup" | ||
with: | ||
python-version: ${{ env.PYTHON_VERSION }} | ||
poetry-version: ${{ env.POETRY_VERSION }} | ||
working-directory: ${{ inputs.working-directory }} | ||
cache-key: release | ||
|
||
# We want to keep this build stage *separate* from the release stage, | ||
# so that there's no sharing of permissions between them. | ||
# The release stage has trusted publishing and GitHub repo contents write access, | ||
# and we want to keep the scope of that access limited just to the release job. | ||
# Otherwise, a malicious `build` step (e.g. via a compromised dependency) | ||
# could get access to our GitHub or PyPI credentials. | ||
# | ||
# Per the trusted publishing GitHub Action: | ||
# > It is strongly advised to separate jobs for building [...] | ||
# > from the publish job. | ||
# https://github.com/pypa/gh-action-pypi-publish#non-goals | ||
- name: Build project for distribution | ||
run: poetry build | ||
working-directory: ${{ inputs.working-directory }} | ||
|
||
- name: Upload build | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: dist | ||
path: ${{ inputs.working-directory }}/dist/ | ||
|
||
- name: Check Version | ||
id: check-version | ||
shell: bash | ||
working-directory: ${{ inputs.working-directory }} | ||
run: | | ||
echo pkg-name="$(poetry version | cut -d ' ' -f 1)" >> $GITHUB_OUTPUT | ||
echo version="$(poetry version --short)" >> $GITHUB_OUTPUT | ||
|
||
test-pypi-publish: | ||
needs: | ||
- build | ||
uses: | ||
./.github/workflows/_test_release.yml | ||
with: | ||
working-directory: ${{ inputs.working-directory }} | ||
secrets: inherit | ||
|
||
pre-release-checks: | ||
needs: | ||
- build | ||
- test-pypi-publish | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
# We explicitly *don't* set up caching here. This ensures our tests are | ||
# maximally sensitive to catching breakage. | ||
# | ||
# For example, here's a way that caching can cause a falsely-passing test: | ||
# - Make the langchain package manifest no longer list a dependency package | ||
# as a requirement. This means it won't be installed by `pip install`, | ||
# and attempting to use it would cause a crash. | ||
# - That dependency used to be required, so it may have been cached. | ||
# When restoring the venv packages from cache, that dependency gets included. | ||
# - Tests pass, because the dependency is present even though it wasn't specified. | ||
# - The package is published, and it breaks on the missing dependency when | ||
# used in the real world. | ||
|
||
- name: Set up Python + Poetry ${{ env.POETRY_VERSION }} | ||
uses: "./.github/actions/poetry_setup" | ||
with: | ||
python-version: ${{ env.PYTHON_VERSION }} | ||
poetry-version: ${{ env.POETRY_VERSION }} | ||
working-directory: ${{ inputs.working-directory }} | ||
|
||
- name: Import published package | ||
shell: bash | ||
working-directory: ${{ inputs.working-directory }} | ||
env: | ||
PKG_NAME: ${{ needs.build.outputs.pkg-name }} | ||
VERSION: ${{ needs.build.outputs.version }} | ||
# Here we use: | ||
# - The default regular PyPI index as the *primary* index, meaning | ||
# that it takes priority (https://pypi.org/simple) | ||
# - The test PyPI index as an extra index, so that any dependencies that | ||
# are not found on test PyPI can be resolved and installed anyway. | ||
# (https://test.pypi.org/simple). This will include the PKG_NAME==VERSION | ||
# package because VERSION will not have been uploaded to regular PyPI yet. | ||
# - attempt install again after 5 seconds if it fails because there is | ||
# sometimes a delay in availability on test pypi | ||
run: | | ||
poetry run pip install \ | ||
--extra-index-url https://test.pypi.org/simple/ \ | ||
"$PKG_NAME==$VERSION" || \ | ||
( \ | ||
sleep 5 && \ | ||
poetry run pip install \ | ||
--extra-index-url https://test.pypi.org/simple/ \ | ||
"$PKG_NAME==$VERSION" \ | ||
) | ||
|
||
# Replace all dashes in the package name with underscores, | ||
# since that's how Python imports packages with dashes in the name. | ||
IMPORT_NAME="$(echo "$PKG_NAME" | sed s/-/_/g)" | ||
|
||
poetry run python -c "import $IMPORT_NAME; print(dir($IMPORT_NAME))" | ||
|
||
- name: Import test dependencies | ||
run: poetry install --with test,test_integration | ||
working-directory: ${{ inputs.working-directory }} | ||
|
||
# Overwrite the local version of the package with the test PyPI version. | ||
- name: Import published package (again) | ||
working-directory: ${{ inputs.working-directory }} | ||
shell: bash | ||
env: | ||
PKG_NAME: ${{ needs.build.outputs.pkg-name }} | ||
VERSION: ${{ needs.build.outputs.version }} | ||
run: | | ||
poetry run pip install \ | ||
--extra-index-url https://test.pypi.org/simple/ \ | ||
"$PKG_NAME==$VERSION" | ||
|
||
- name: Run unit tests | ||
run: make tests | ||
working-directory: ${{ inputs.working-directory }} | ||
|
||
- name: 'Authenticate to Google Cloud' | ||
id: 'auth' | ||
uses: google-github-actions/auth@v2 | ||
with: | ||
credentials_json: '${{ secrets.GOOGLE_CREDENTIALS }}' | ||
|
||
- name: Run integration tests | ||
env: | ||
GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }} | ||
run: make integration_tests | ||
working-directory: ${{ inputs.working-directory }} | ||
|
||
- name: Get minimum versions | ||
working-directory: ${{ inputs.working-directory }} | ||
id: min-version | ||
run: | | ||
poetry run pip install packaging | ||
min_versions="$(poetry run python $GITHUB_WORKSPACE/.github/scripts/get_min_versions.py pyproject.toml)" | ||
echo "min-versions=$min_versions" >> "$GITHUB_OUTPUT" | ||
echo "min-versions=$min_versions" | ||
|
||
- name: Run unit tests with minimum dependency versions | ||
if: ${{ steps.min-version.outputs.min-versions != '' }} | ||
env: | ||
MIN_VERSIONS: ${{ steps.min-version.outputs.min-versions }} | ||
run: | | ||
poetry run pip install $MIN_VERSIONS | ||
make tests | ||
working-directory: ${{ inputs.working-directory }} | ||
|
||
publish: | ||
needs: | ||
- build | ||
- test-pypi-publish | ||
- pre-release-checks | ||
runs-on: ubuntu-latest | ||
permissions: | ||
# This permission is used for trusted publishing: | ||
# https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/ | ||
# | ||
# Trusted publishing has to also be configured on PyPI for each package: | ||
# https://docs.pypi.org/trusted-publishers/adding-a-publisher/ | ||
id-token: write | ||
|
||
defaults: | ||
run: | ||
working-directory: ${{ inputs.working-directory }} | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Python + Poetry ${{ env.POETRY_VERSION }} | ||
uses: "./.github/actions/poetry_setup" | ||
with: | ||
python-version: ${{ env.PYTHON_VERSION }} | ||
poetry-version: ${{ env.POETRY_VERSION }} | ||
working-directory: ${{ inputs.working-directory }} | ||
cache-key: release | ||
|
||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: dist | ||
path: ${{ inputs.working-directory }}/dist/ | ||
|
||
- name: Publish package distributions to PyPI | ||
uses: pypa/gh-action-pypi-publish@release/v1 | ||
with: | ||
packages-dir: ${{ inputs.working-directory }}/dist/ | ||
verbose: true | ||
print-hash: true | ||
|
||
mark-release: | ||
needs: | ||
- build | ||
- test-pypi-publish | ||
- pre-release-checks | ||
- publish | ||
runs-on: ubuntu-latest | ||
permissions: | ||
# This permission is needed by `ncipollo/release-action` to | ||
# create the GitHub release. | ||
contents: write | ||
|
||
defaults: | ||
run: | ||
working-directory: ${{ inputs.working-directory }} | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Python + Poetry ${{ env.POETRY_VERSION }} | ||
uses: "./.github/actions/poetry_setup" | ||
with: | ||
python-version: ${{ env.PYTHON_VERSION }} | ||
poetry-version: ${{ env.POETRY_VERSION }} | ||
working-directory: ${{ inputs.working-directory }} | ||
cache-key: release | ||
|
||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: dist | ||
path: ${{ inputs.working-directory }}/dist/ | ||
|
||
- name: Create Release | ||
uses: ncipollo/release-action@v1 | ||
with: | ||
artifacts: "dist/*" | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
draft: false | ||
generateReleaseNotes: true | ||
tag: ${{ inputs.working-directory }}/v${{ needs.build.outputs.version }} | ||
commit: master |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's disable this maybe until we don't migrate to new integration testing component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer to keep integration tests running before releases! What is the new component? New script?