Update AstraDBGraphVectorStore to match implementation of CassandraGraphVectorStore #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epinzur
force-pushed
the
revise_graph
branch
5 times, most recently
from
9605073 to
a14af29
Compare
epinzur
changed the title
|
You may find it convenient to merge the latest main, which introduces management for a new scheme of "callers" (i.e. user-agent management down to the astrapy layer). For the gvs.py file, this amounts to accepting (and passing down to the VectorStore) a couple of kwargs more. |
epinzur
commented
Oct 14, 2024
libs/astradb/tests/integration_tests/test_upgrade_to_graphvectorstore.py
Outdated
Show resolved
Hide resolved
epinzur
commented
Oct 14, 2024
libs/astradb/tests/integration_tests/test_upgrade_to_graphvectorstore.py
Outdated
Show resolved
Hide resolved
epinzur
commented
Oct 15, 2024
epinzur
commented
Oct 15, 2024
epinzur
commented
Oct 15, 2024
epinzur
commented
Oct 15, 2024
epinzur
commented
Oct 15, 2024
epinzur
commented
Oct 15, 2024
hemidactylus
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corresponds with langchain-ai/langchain#27253 which implements changes for
CassandraGraphVectorStore.After both are merged, both implementations will be nearly identical, and we can look into creating some shared code.