generated from langchain-ai/integration-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jasonozuzu/pts 7374 langchain chat v2 (stream added) #103
Open
jasonozuzu-cohere
wants to merge
46
commits into
langchain-ai:main
Choose a base branch
from
jasonozuzu-cohere:jasonozuzu/pts-7374-langchain-chat-v2-NOSTREAM
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jasonozuzu/pts 7374 langchain chat v2 (stream added) #103
jasonozuzu-cohere
wants to merge
46
commits into
langchain-ai:main
from
jasonozuzu-cohere:jasonozuzu/pts-7374-langchain-chat-v2-NOSTREAM
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonozuzu-cohere
requested review from
GangGreenTemperTatum,
harry-cohere,
BeatrixCohere,
billytrend-cohere,
minjie-cohere,
pat-cohere,
Anirudh31415926535 and
a team
as code owners
October 11, 2024 14:26
jasonozuzu-cohere
changed the title
Jasonozuzu/pts 7374 langchain chat v2 (NO-STREAM)
Jasonozuzu/pts 7374 langchain chat v2 (STREAM INCLUDED)
Oct 30, 2024
jasonozuzu-cohere
changed the title
Jasonozuzu/pts 7374 langchain chat v2 (STREAM INCLUDED)
Jasonozuzu/pts 7374 langchain chat v2 (stream added)
Oct 31, 2024
harry-cohere
added a commit
that referenced
this pull request
Nov 27, 2024
#103 removes connector functionality (yet to be deprecated) as well as the `create_cohere_tools_agent` function (deprecated since 0.1.7). This PR marks this functionality as deprecated so that version 0.3.3+ will show a warning.
billytrend-cohere
previously approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stepped through with @jasonozuzu-cohere and fixed a couple things but lgtm!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to langchain-cohere to rely on v2 of our chat API.
Both streaming and non-streaming use cases are supported