Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature php 8.2 update #93

Closed
wants to merge 5 commits into from
Closed

Feature php 8.2 update #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8127c80
Update PHP 7.4 to 8.1 and references to the default version
rubenvarela Mar 19, 2024
d1d3e0c
Update Drush 8 to avoid warning on 8.1
rubenvarela Mar 19, 2024
f12491c
Upgrade PHP from 8.1 to 8.2 to match Acquia's default
rubenvarela Apr 5, 2024
8542a74
Explicitly mention in the documentation that we'll default to latest PHP
rubenvarela Apr 5, 2024
97222b8
Trigger Build
rubenvarela Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builders/acquia-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const utils = require('../lib/utils.js');
const warnings = require('../lib/warnings.js');

// "Constants"
const DRUSH8 = '8.4.8';
const DRUSH8 = '8.4.10';
const DRUSH7 = '7.4.0';

// Tooling defaults
Expand Down
4 changes: 2 additions & 2 deletions builders/acquia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ module.exports = {
composer_version: '2',
confSrc: path.resolve(__dirname, '..', 'config'),
defaultFiles: {},
drush: '8.4.8',
drush: '8.4.10',
inbox: true,
php: '7.4',
php: '8.2',
services: {appserver: {
build: [],
overrides: {volumes: [], environment: {}},
Expand Down
6 changes: 4 additions & 2 deletions docs/config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ config:
cache: true
composer_version: '2'
inbox: true
php: '7.4'
php: '8.2'
xdebug: false
```

Expand Down Expand Up @@ -56,7 +56,9 @@ By default, Lando will spin up an approximation of the Acquia stack:
* Apache webserver `2.4`
* MySQL database server `5.7`
* Memcache `1.6`
* PHP `7.3`, `7.4`
* PHP `8.2`

Where acquia provider multiple options, we'll choose the current default. PHP is a good example.

Not current supported but coming soon:

Expand Down
2 changes: 1 addition & 1 deletion examples/acquia-custom/.lando.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: acquia-custom
recipe: acquia
config:
php: '8.1'
php: '8.2'
composer_version: '2.0.7'
xdebug: true
inbox: false
Expand Down
4 changes: 2 additions & 2 deletions examples/drupal/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ lando composer --version | grep Composer | grep 2.
cd drupal9
lando ssh -c "/usr/local/bin/composer --version" | grep Composer | grep "2.0.11"

# Should use php version 7.4 by default
# Should use php version 8.2 by default
cd drupal9
lando php -v | grep "PHP 8.1"
lando php -v | grep "PHP 8.2"

# Should be able to bootstrap drupal9
cd drupal9
Expand Down
Loading