Fix warning in SessionManager::destroy() for headers already sent and actual fix for trying to destroy non-existent session #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksip
changed the title
Signed-off-by: Aleksi Peebles <[email protected]>
aleksip
force-pushed
the
fix-early-return
branch
from
e8b4312 to
50ad6ff
Compare
…t test Signed-off-by: Aleksi Peebles <[email protected]>
Xerkus
reviewed
Feb 29, 2024
Xerkus
changed the title
Co-authored-by: Aleksei Khudiakov <[email protected]> Signed-off-by: Aleksi Peebles <[email protected]>
Signed-off-by: Aleksi Peebles <[email protected]>
Xerkus
approved these changes
Feb 29, 2024
|
@aleksip thank you |
|
Very nice - and looks to be a more thorough solution. Nice work, everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem introduced by #79
#79 introduced a fix for trying to destroy non-existent session when headers were already sent. However fix inadvertently prevented valid attempts to destroy session when session is active but headers were already sent.