Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] introduce Psalm #53

Closed
wants to merge 179 commits into from
Closed

[develop] introduce Psalm #53

wants to merge 179 commits into from

Conversation

sasezaki
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

This PR aims to setup psalm instead of PHPStan. #48

weierophinney and others added 30 commits March 1, 2017 16:08
removed duplicate allow_failures
Updated packages in composer to latest stable version and PHP requirements
changed to PHP ^7.1
Updated suggestion in composer.
Those optimizations target improving OPCODES.
…l-functions

Import PHP internal functions
replace count() usage to empty() when possible
GeeH and others added 20 commits June 5, 2020 11:48
Signed-off-by: Gary Hockin <[email protected]>
Signed-off-by: Gary Hockin <[email protected]>
Signed-off-by: Gary Hockin <[email protected]>
Signed-off-by: Gary Hockin <[email protected]>
Signed-off-by: Gary Hockin <[email protected]>
Signed-off-by: Gary Hockin <[email protected]>
…d-repo

laminas#3 Ported 279 from ZF repository - fixes merging of duplicate delegator factory definitions
…version-php7.4

Updated mimumum PHP version to 7.4 and tried to add 8.0 to CI
@@ -41,7 +41,8 @@
"mikey179/vfsstream": "^1.6.8",
"ocramius/proxy-manager": "^2.8",
"phpbench/phpbench": "^0.17",
"phpunit/phpunit": "^7.5.20"
"phpunit/phpunit": "^7.5.20",
"vimeo/psalm": "^3.13"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs composer v2.

Because ...

$ sudo composer self-update --stable
Upgrading to version 1.10.10 (stable channel).
$ rm composer.lock & composer install
$ composer require --dev vimeo/psalm
Using version ^3.13 for vimeo/psalm
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: don't install vimeo/psalm 3.13.1
    - Conclusion: remove ocramius/package-versions 1.9.0
    - Installation request for vimeo/psalm ^3.13 -> satisfiable by vimeo/psalm[3.13.0, 3.13.1].
    - Conclusion: don't install ocramius/package-versions 1.9.0
    - vimeo/psalm 3.13.0 requires composer/package-versions-deprecated ^1.8.0 -> satisfiable by composer/package-versions-deprecated[1.10.99, 1.10.99.1, 1.8.0, 1.8.1, 1.8.2].
    - don't install composer/package-versions-deprecated 1.10.99|don't install ocramius/package-versions 1.9.0
    - don't install composer/package-versions-deprecated 1.10.99.1|don't install ocramius/package-versions 1.9.0
    - don't install composer/package-versions-deprecated 1.8.0|don't install ocramius/package-versions 1.9.0
    - don't install composer/package-versions-deprecated 1.8.1|don't install ocramius/package-versions 1.9.0
    - don't install composer/package-versions-deprecated 1.8.2|don't install ocramius/package-versions 1.9.0
    - Installation request for ocramius/package-versions (locked at 1.9.0) -> satisfiable by ocramius/package-versions[1.9.0].


Installation failed, reverting ./composer.json to its original content.

Copy link
Contributor Author

@sasezaki sasezaki Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, if we can allow to use composer v2 as dev tools,
.travis.yml also needs composer self-update --2, OR
needs introducing specific GitHub Action for psalm.

Could anyone help for ocramius/proxy-manager:^2.9 & composer v2 dev dependency problem ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to pin to ocramius/proxy-manager:^2.8.0, as that's compatible with both composer releases

@geerteltink geerteltink changed the base branch from develop to 3.5.x September 12, 2020 09:21
@boesing boesing linked an issue Nov 17, 2020 that may be closed by this pull request
8 tasks
@boesing
Copy link
Member

boesing commented May 16, 2021

Closing this in favor of #65

@boesing boesing closed this May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Psalm integration