fix: LazyServiceFactory does not reset initializer in proxy class when building dependency fails #250
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xy class when building dependency fails Signed-off-by: vdmorozov <[email protected]>
|
If possible, please create a patch release for the 3-rd version with this fix |
Signed-off-by: vdmorozov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where an exception thrown during lazy service initialization would leave the proxy in an invalid state. The fix ensures that the original initializer isn't reset when an exception occurs, allowing subsequent initialization attempts to work correctly.
Added tests to verify the behavior.