-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow varexporter v0.5 #237
Conversation
Signed-off-by: Witold Wasiczko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With latest dependencies, this still installed 0.4.x
- Downloading brick/varexporter (0.4.0)
Yeah, probably same like here :-( laminas/laminas-config-aggregator#45 |
This is because |
Wait, why service manager needs var exporter? |
|
So signature VarExporter::export backward compatibility between v0.4 & v0.5 I believe we can safe merge this PR without any consequences... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 then :-)
Thanks @snapshotpl @mrVrAlex @kersysgediminas |
Description
Support for brick/varexporter v0.5.0 to turn supports nikic/PHP-Parser v5 and enabling upgrades to PHPUnit 11 in downstream projects.