Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow varexporter v0.5 #237

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

snapshotpl
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Support for brick/varexporter v0.5.0 to turn supports nikic/PHP-Parser v5 and enabling upgrades to PHPUnit 11 in downstream projects.

Signed-off-by: Witold Wasiczko <[email protected]>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With latest dependencies, this still installed 0.4.x

- Downloading brick/varexporter (0.4.0)

@snapshotpl
Copy link
Member Author

Yeah, probably same like here :-( laminas/laminas-config-aggregator#45

@kersysgediminas
Copy link

kersysgediminas commented Jun 11, 2024

@Ocramius

With latest dependencies, this still installed 0.4.x

- Downloading brick/varexporter (0.4.0)

This is because brick/varexporter (0.5.0) requires nikic/php-parser (5.0.0), but vimeo/psalm only supports nikic/php-parser (4.0.0). However vimeo/psalm is only used in require-dev, therefore brick/varexporter (0.5.0) wouldn't be blocked when installing laminas/laminas-servicemanager as a required dependency

@Xerkus
Copy link
Member

Xerkus commented Jun 11, 2024

Wait, why service manager needs var exporter?

@snapshotpl
Copy link
Member Author

VarExporter::NO_CLOSURES | VarExporter::NO_SERIALIZE | VarExporter::NO_SERIALIZE | VarExporter::NO_SET_STATE

@mrVrAlex
Copy link

mrVrAlex commented Jul 4, 2024

So signature VarExporter::export backward compatibility between v0.4 & v0.5 I believe we can safe merge this PR without any consequences...

@Ocramius Ocramius added this to the 4.2.0 milestone Jul 4, 2024
@Ocramius Ocramius self-assigned this Jul 4, 2024
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 then :-)

@Ocramius Ocramius merged commit a8489e3 into laminas:4.2.x Jul 4, 2024
12 checks passed
@Ocramius
Copy link
Member

Ocramius commented Jul 4, 2024

Thanks @snapshotpl @mrVrAlex @kersysgediminas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants