Skip to content

Commit

Permalink
Merge pull request #179 from boesing/feature/plugin-manager-composition
Browse files Browse the repository at this point in the history
Remove `ServiceManager` inheritance for `AbstractPluginManager`
  • Loading branch information
boesing authored May 2, 2023
2 parents 72afe94 + 8469e6d commit 3d870a0
Show file tree
Hide file tree
Showing 56 changed files with 1,389 additions and 3,054 deletions.
6 changes: 0 additions & 6 deletions .laminas-ci.json

This file was deleted.

4 changes: 2 additions & 2 deletions benchmarks/BenchAsset/AbstractFactoryFoo.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
class AbstractFactoryFoo implements AbstractFactoryInterface
{
/** {@inheritDoc} */
public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null)
public function __invoke(ContainerInterface $container, string $requestedName, ?array $options = null): mixed
{
if ($requestedName === 'foo') {
return new Foo($options);
Expand All @@ -19,7 +19,7 @@ public function __invoke(ContainerInterface $container, $requestedName, ?array $
}

/** {@inheritDoc} */
public function canCreate(ContainerInterface $container, $requestedName)
public function canCreate(ContainerInterface $container, string $requestedName): bool
{
return $requestedName === 'foo';
}
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/BenchAsset/FactoryFoo.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
class FactoryFoo implements FactoryInterface
{
/** {@inheritDoc} */
public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null)
public function __invoke(ContainerInterface $container, string $requestedName, ?array $options = null): mixed
{
return new Foo($options);
}
Expand Down
27 changes: 14 additions & 13 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,19 @@
},
"config": {
"platform": {
"php": "8.0.99"
"php": "8.1.99"
},
"sort-packages": true,
"allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true,
"composer/package-versions-deprecated": true,
"laminas/laminas-dependency-plugin": true
"composer/package-versions-deprecated": true
}
},
"require": {
"php": "~8.0.0 || ~8.1.0 || ~8.2.0",
"php": "~8.1.0 || ~8.2.0",
"brick/varexporter": "^0.3.8",
"laminas/laminas-stdlib": "^3.2.1",
"psr/container": "^1.0"
"psr/container": "^1.1"
},
"extra": {
"laminas": {
Expand All @@ -48,16 +47,15 @@
"composer/package-versions-deprecated": "^1.11.99.5",
"laminas/laminas-cli": "^1.8",
"laminas/laminas-coding-standard": "~2.5.0",
"laminas/laminas-container-config-test": "^0.8",
"laminas/laminas-dependency-plugin": "^2.2",
"laminas/laminas-container-config-test": "dev-qa/service-manager-v4",
"lctrs/psalm-psr-container-plugin": "^1.9",
"mikey179/vfsstream": "^1.6.11@alpha",
"ocramius/proxy-manager": "^2.14.1",
"friendsofphp/proxy-manager-lts": "^1",
"phpbench/phpbench": "^1.2.7",
"phpunit/phpunit": "^9.5.26",
"psalm/plugin-phpunit": "^0.18.0",
"symfony/console": "^6.0",
"vimeo/psalm": "^5.0.0"
"vimeo/psalm": "^5.10"
},
"provide": {
"psr/container-implementation": "^1.0"
Expand All @@ -68,17 +66,14 @@
},
"suggest": {
"laminas/laminas-cli": "To consume CLI commands provided by this component",
"ocramius/proxy-manager": "ProxyManager ^2.1.1 to handle lazy initialization of services"
"friendsofphp/proxy-manager-lts": "To handle lazy initialization of services"
},
"autoload": {
"psr-4": {
"Laminas\\ServiceManager\\": "src/"
}
},
"autoload-dev": {
"files": [
"test/autoload.php"
],
"psr-4": {
"LaminasTest\\ServiceManager\\": "test/",
"LaminasBench\\ServiceManager\\": "benchmarks/"
Expand All @@ -95,5 +90,11 @@
"test": "phpunit --colors=always",
"test-coverage": "phpunit --colors=always --coverage-clover clover.xml",
"static-analysis" : "psalm --shepherd --stats"
},
"repositories": {
"container-integration-tests": {
"type": "git",
"url": "https://github.com/boesing/laminas-container-config-test"
}
}
}
Loading

0 comments on commit 3d870a0

Please sign in to comment.