Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for TH 2.21 #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for TH 2.21 #22

wants to merge 1 commit into from

Conversation

expipiplus1
Copy link

No description provided.

yairchu added a commit that referenced this pull request Sep 9, 2024
@yairchu
Fixes for build with GHC 9.8.2 env (stackage nightly-2024-09-09)
186aac2 
Original fix suggested in #22
broke build with stackage lts-22.33 and this variant maintains compatibility across versions.
@yairchu
Copy link
Member

yairchu commented Sep 9, 2024

Thanks! I've tried the suggested fix on my stackage lts-22.33 env and it didn't compile due to not being compatible with older template-haskell versions, so I've used compat helper Language.Haskell.TH.Datatype.TyVarBndr.defaultBndrFlag instead of BndrReq and this seems to work across versions for me.

Does it work for you now?

@expipiplus1
Copy link
Author

Yeah, that works well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@expipiplus1 @yairchu