Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update logging for failed async operations (radius-project#7370)
# Description Controllers currently have two ways of bubbling up errors to the async worker: 1. By returning the error, which is then added to the result by the async worker. 2. By directly returning a non-empty result with error message populated and provisioning state set to "failed". We have a few gaps in the logging today which results into false data or no data, this PR aims to fix these gaps - * Error is not logged if it is returned as a part of the result (scenario 2 above). * Operation is logged as successful if a direct error is returned (scenario 1 above). * Provisioning state is set to succeeded even if the controller returns an error (scenario 1 above). ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Part of radius-project#7369 --------- Signed-off-by: karishma-chawla <[email protected]> Co-authored-by: karishma-chawla <[email protected]>
- Loading branch information