Use std::mt19937 to replace mt_random. #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least 1 approving review is required by reviewers with write access. |
lailongwei
requested changes
Sep 11, 2023
| @@ -21,8 +21,8 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <random> | |||
There was a problem hiding this comment.
建议进行优化：
#include <random>放到OSHeader.h中（找到合适位置） or 考虑隐藏std::mt19937实现（即RandomInl.h改名为Random.cpp，但会有可能性能损失（call 性能））
| @@ -30,19 +30,19 @@ inline LLBC_Random::LLBC_Random(int seed) | |||
|
|
|||
| inline void LLBC_Random::Seed(int seed) | |||
| { | |||
| _mtRand.reset(seed); | |||
| _mtRand.seed(seed); | |||
There was a problem hiding this comment.
建议查阅api文档，确保Seed()接口跟seed()的参数类型一致
| } | ||
|
|
||
| inline int LLBC_Random::Rand(int end) | ||
| { | ||
| if (LIKELY(end != 0)) | ||
| { | ||
| const long long randVal = llabs(static_cast<int>(_mtRand.rand())); | ||
| const long long randVal = llabs(static_cast<int>(_mtRand())); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use td::mt19937 to replace mt_random.