Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env : Dev 환경 세팅 #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Env : Dev 환경 세팅 #1

wants to merge 3 commits into from

Conversation

JerryK026
Copy link
Contributor

No description provided.

@JerryK026 JerryK026 requested a review from minseongkimdev May 30, 2022 07:00
Copy link
Contributor

@minseongkimdev minseongkimdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중간중간에 .DS_Store파일들이 섞여있네요! .gitignore에 추가해주시면 좋을것 같습니다!

Copy link
Contributor

@minseongkimdev minseongkimdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰드린거 확인 부탁드릴게요!

spring:
datasource:
driver-class-name: com.mysql.cj.jdbc.Driver
# url: jdbc:mysql://127.0.0.1:3306/test_db?serverTimezone=Asia/Seoul&charset=UTF-8&useSSL=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 주석은 없어도 될것 같습니다!

### VS Code ###
.vscode/

/mysql/mysql_data/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음 사이트에서 생성해주는 .gitIgnore를 활용해봐도 좋을것 같습니다!
https://www.toptal.com/developers/gitignore

개발환경이 MacOS이니 다음 내용이 추가되어도 좋을것 같습니다!

# Created by https://www.toptal.com/developers/gitignore/api/macos
# Edit at https://www.toptal.com/developers/gitignore?templates=macos

### macOS ###
# General
.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon


# Thumbnails
._*

# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent

# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk

### macOS Patch ###
# iCloud generated files
*.icloud

# End of https://www.toptal.com/developers/gitignore/api/macos

id 'java'
}

group = 'com.salgirl'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group 이름 다시 확인 부탁드립니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저희 레포 이름이 라고할떄라 살걸로 했는데 별로인가요?
라고할때.살걸.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants