Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of asv benchmark #21

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

agoscinski
Copy link
Collaborator

Draft of asv benchmark. Can be run with tox -e benchmarks

@agoscinski
Copy link
Collaborator Author

Float32 fail and CI runs through. Need to find a way that a failure in benchmarks results in a failure of CI

@agoscinski
Copy link
Collaborator Author

Because the computation of the input for the code that is benchmarked is very slow (30s on CI), we need to cache it on disk (class variables don't work, they are also multiple times initialized). Main problem for caching the inputs is that one needs to pickle them. The current Spline is not pickable, because it uses local definition of functions (equistore.Labels is also not pickable, but the workaround is rather simple). I would proceed when metatensor/featomic#212 is merged and then using the same Spliner to also not have duplicated code in the two repos. That introduces a dependency on rascaline, but so be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant