Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove todo #42

Merged
merged 2 commits into from
Oct 4, 2023
Merged

chore: remove todo #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8296eb
chore: remove todo
eddycharly Oct 4, 2023
f96d57d
Merge branch 'main' into todo
eddycharly Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/engine/assert/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ func (n *scalarNode) assert(path *field.Path, value interface{}, bindings bindin
expression := parseExpression(rhs)
// we only project if the expression uses the engine syntax
// this is to avoid the case where the value is a map and the RHS is a string
// TODO: we need a way to escape the projection
if expression != nil && expression.engine != "" {
if expression.foreachName != "" {
return nil, field.Invalid(path, rhs, "foreach is not supported on the RHS")
Expand Down
Loading