-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerized #99
Dockerized #99
Conversation
Could you add a section in the readme explaining how to use the docker image? Then I can accept the PR. |
@adefossez done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments before I can merge to be sure I properly understand what is going on.
@@ -0,0 +1,40 @@ | |||
version: "3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it's been removed and it's ignored now.
https://docs.docker.com/reference/compose-file/version-and-name/
pull_policy: always | ||
restart: unless-stopped | ||
expose: | ||
- 43337/tcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure how the tunneling is supposed to work, is it on top of the gradio tunnel ? In that case I would remove the gradio flag in the other docker file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not on top of, but next to. I use this for all of my deployments. If you add a token then you can have a static URL on your own domain. I left it so people can have options and learn about cloudflare tunnels.
Thanks a lot, merged! |
Checklist
cargo check
,cargo clippy
,cargo test
.PR Description
Added Dockerfiles and docker compose to run the service on a Linux with the NVIDIA Container Toolkit
Docker Server setup
Install the NVIDIA Container Toolkit
https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html
Start the docker container
docker compose up