added moshi-* scripts/entrypoints to pyproject.toml
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adefossez
reviewed
Sep 19, 2024
|
Also you need to agree to the CLA by following the instructions in contributing.md |
ErikBjare
force-pushed
the
dev/add-pyproject-scripts
branch
from
646f664 to
cdc80c3
Compare
|
Alright, fixed it up and got it running now. Very cool! Let me know if there's anything else I should do. |
ErikBjare
commented
Sep 19, 2024
ErikBjare
changed the title
moshi-server scripts/entrypoints to pyproject.tomlmoshi-* scripts/entrypoints to pyproject.toml
ErikBjare
force-pushed
the
dev/add-pyproject-scripts
branch
from
cdc80c3 to
1d864b7
Compare
ErikBjare
commented
Sep 19, 2024
adefossez
reviewed
Sep 19, 2024
|
final nit before I can accept |
ErikBjare
force-pushed
the
dev/add-pyproject-scripts
branch
from
1d864b7 to
f03dc61
Compare
|
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo check,cargo clippy,cargo test.CLA
I, Erik Bjäreholt (@ErikBjare), confirm that I have read and understood the terms of the CLA of Kyutai-labs, as outlined in the repository's CONTRIBUTING.md, and I agree to be bound by these terms.
PR Description
With this change you can now install moshi with:
pipx install moshi(once it's on PyPI)pipx install -e ./moshi/moshi(which I tested)This wasn't possible before since pipx requires a valid entrypoint to allow installation.