Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial smoke-test framework for docker testimages #9330

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

Ressetkk
Copy link
Contributor

/kind feature
/area ci

Added small framework that allows to define small test script that allows doing some work around the Docker context. I've added small tests around basic functionalities and binary presence. Script results outputs are collected to the ARTIFACTS directory and if any error occurs, the build loop is interrupted, returning non-zero exit code. The functionality docu is provided for anyone who wants to add another smoke test for new or existing image.

Closes #8938

@Ressetkk Ressetkk requested review from halamix2 and the1bit November 17, 2023 16:05
@kyma-bot kyma-bot added kind/feature Categorizes issue or PR as related to a new feature. area/ci Issues or PRs related to CI related topics size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2023
@Ressetkk Ressetkk force-pushed the image-smoke-test branch 8 times, most recently from e0510e3 to 344071e Compare November 20, 2023 10:36
/kind feature
/area ci

Added small framework that allows to define small test script that allows doing some work around the Docker context.
I've added small tests around basic functionalities and binary presence.
Script results outputs are collected to the ARTIFACTS directory and if any error occurs, the build loop is interrupted, returning non-zero exit code.
The functionality docu is provided for anyone who wants to add another smoke test for new or existing image.
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2023
@Ressetkk
Copy link
Contributor Author

/retest

images/README.md Outdated Show resolved Hide resolved
images/README.md Outdated Show resolved Hide resolved
images/README.md Outdated Show resolved Hide resolved
images/README.md Outdated Show resolved Hide resolved
images/README.md Outdated Show resolved Hide resolved
@Ressetkk
Copy link
Contributor Author

/retest

@Ressetkk Ressetkk requested a review from IwonaLanger November 21, 2023 12:53
@halamix2
Copy link
Member

/retest

/kind chore
/area ci

Updating testimages dependencies to new versions.
@Ressetkk
Copy link
Contributor Author

/cla

1 similar comment
@Ressetkk
Copy link
Contributor Author

/cla

@kyma-bot
Copy link
Contributor

Successfully reached out to cla-assistant.io to initialize recheck of PR #9330

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 22, 2023
@kyma-bot
Copy link
Contributor

@Ressetkk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-test-infra-presubmit-scanner cd02ab5 link false /test pre-test-infra-presubmit-scanner

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@halamix2 halamix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/pony

@kyma-bot
Copy link
Contributor

@halamix2: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot merged commit 2a5515a into kyma-project:main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Implement smoke-test for container images created by Neighbors
4 participants