Merge pull request #85 from kuzzleio/fix-refresh-param-getter

What does this PR do?

Add a missing propagated refresh parameter to a user creation to fix this kind of inconsistent database (https://github.com/kuzzleio/kuzzle/runs/4934352096?check_suite_focus=true#step:6:439)

Boyscout

Use KuzzleRequest.getRefresh instead of KuzzleRequest.getString to retrieve the refresh parameter

lib/index.js

@@ -380,7 +380,7 @@ class AuthenticationPlugin {
    * @returns {Promise<object>}
    */
   async create (request, credentials, kuid) {
-    const refresh = request.getString('refresh', 'wait_for');
+    const refresh = request.getRefresh('wait_for');
 
     if (!credentials.password) {
       throw new this.context.errors.BadRequestError('Password needed.');
@@ -420,7 +420,7 @@ class AuthenticationPlugin {
    * @returns {Promise<object>}
    */
   async update (request, credentials, kuid) {
-    const refresh = request.getString('refresh', 'wait_for');
+    const refresh = request.getRefresh('wait_for');
 
     if (credentials.kuid) {
       throw new this.context.errors.BadRequestError('The request must not contain a kuid attribute.');
@@ -480,8 +480,7 @@ class AuthenticationPlugin {
       newDocument._id = credentials.username;
       delete newDocument.username;
 
-      updated = await this.getUsersRepository().create(newDocument);
-      // wait for refresh only after the 2nd action
+      updated = await this.getUsersRepository().create(newDocument, { refresh });
       await this.getUsersRepository().delete(oldDocumentId, { refresh });
     }
     else {
@@ -501,7 +500,7 @@ class AuthenticationPlugin {
    * @returns {Promise<object>}
    */
   async delete (request, kuid) {
-    const refresh = request.getString('refresh', 'wait_for');
+    const refresh = request.getRefresh('wait_for');
 
     const user = await this.getCredentialsFromUserId(kuid);
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "kuzzle-plugin-auth-passport-local",
-  "version": "6.3.5",
+  "version": "6.3.6",
   "description": "Kuzzle plugin to log-in users",
   "main": "./lib/index.js",
   "repository": {