Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support atlas migration, issueref #56 #57

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: support atlas migration, issueref #56 #57

wants to merge 4 commits into from
+111 −5

Conversation

shreyasHpandya
Copy link

No description provided.

@shreyasHpandya shreyasHpandya force-pushed the main branch 3 times, most recently from b6c1c91 to ec04c2a Compare November 21, 2024 04:43
@shreyasHpandya shreyasHpandya changed the title [DRAFT]feat: support atlas migration, issueref #56 feat: support atlas migration, issueref #56 Nov 26, 2024
@sunnyyip
Copy link
Contributor

sunnyyip commented Dec 3, 2024

Thanks for the PR, @shreyasHpandya, @semmet95 @ANIRUDH-333!

May I ask you to help me documenting the new features?

  1. We use readme-generator to generate docs for the inputs. Can we add the docs for "atlas" in values.yaml please?
    This is how I run readme-generator at helm-charts/charts/guac: readme-generator-for-helm/bin/readme-generator -v ./values.yaml -r ./README.md -s schema.json
  2. Can you please share your learning on running atlas migration? Perhaps a little "Atlas Migration" section under "Install Chart" to call out the importance?
    E.g.
  • do you keep atlas.enabled on or only during version upgrade?
  • Is it ok to run multiple replicas of graphql-server while atlas.enabled is on?
  • Order of operations for migration...etc.

@shreyasHpandya @semmet95
feat: adds atlas migration migration, issueref kusaridev#56
cbfea9e 
* adds atlas init container to graphql-server deployment
* updates readme docs
* updates guac version
* updates chart version

Signed-off-by: Amit Singh <[email protected]>
Signed-off-by: Ayush Shyam Kumar <[email protected]>
Signed-off-by: Anirudh Edpuganti <[email protected]>
Signed-off-by: Shreyas Pandya <[email protected]>
@ANIRUDH-333
Copy link

Hi @sunnyyip . Thank you for sharing the instructions on how to update the PR.
We have followed it and updated the PR to include all the params in Readme file. Please review these changes and let us know if there is anything else that needs to be added/changed to the documentation.
We are still working on the second point you mentioned.

@semmet95
Copy link
Contributor

semmet95 commented Dec 12, 2024 •
edited
Loading

Fixes: #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreyasHpandya @sunnyyip @ANIRUDH-333 @semmet95