feat: improve access to the EMUI 'ports' fields #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dartoxian
changed the title
adschwartz
approved these changes
Feb 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
## Description: This PR adds some fixes to the enclave builder based on feedback received on slack.: * Show the enclave builder in a drawer * Reorder the ports input * Prevent self referencing variables * Don't require a slash prefix on file names ## Is this change user facing? YES ## References (if applicable): * This PR is based on top of #2201 .
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.87.2](0.87.1...0.87.2) (2024-02-23) ### Features * EMUI handle loading a package (or subpackage) from github urls ([#2207](#2207)) ([e584751](e584751)) * enclave builder imagespec support ([#2206](#2206)) ([f0e316e](f0e316e)) * enclave builder improvements from feedback ([#2202](#2202)) ([003005c](003005c)) * improve access to the EMUI 'ports' fields ([#2201](#2201)) ([486ea2e](486ea2e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]> Co-authored-by: Ben Gazzard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves the accessibility of service ports per #2188. Specifically it shows (clickable) named ports on the enclave list and enclave overview screens. Additionally the services in an enclave are shown once the enclave logs have successfully finished.
Screenshots
Is this change user facing?
YES
References (if applicable):