feat: use description field in emui logs #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Feb 21, 2024
adschwartz
approved these changes
Feb 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
🤖 I have created a release *beep* *boop* --- ## [0.87.1](0.87.0...0.87.1) (2024-02-21) ### Features * use description field in emui logs ([#2199](#2199)) ([ad00ee1](ad00ee1)) ### Bug Fixes * admonition in github guide ([#2195](#2195)) ([c2d4d42](c2d4d42)) * Fix the connect to enclave CLI commands in the EM UI ([#2203](#2203)) ([2218f4b](2218f4b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR uses the new
descriptionfield in the enclave logs viewer. By default this field is now used to render starlark instructions, rather than the raw field (from #2147 ).Demo
description-toggle.mp4
Is this change user facing?
Yes
References (if applicable):