feat: add version cmd #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
reviewed
Oct 15, 2024
leoporoli
reviewed
Oct 16, 2024
scripts/generate_kardinal_version.sh
Outdated
| @@ -0,0 +1,54 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Do we need this file? because I see there is a nix version
There was a problem hiding this comment.
we actually don't im gonna remove those
There was a problem hiding this comment.
get-docker-tag.sh is called by generate_kardinal_version.nix I wonder is there is a way to replace it with the nix version of this script?
There was a problem hiding this comment.
ye i'm actually gonna embed the code for that directly in the generate nix
leoporoli
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #275