-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Fixup crash if no --var param is passed If no var is passed, the args.var will be set to None. Trying to iterate on None throws the following exception: TypeError: 'NoneType' object is not iterable The function now only processes the list if it's defined * Fixup crash when filefilter contains empty lines The RemoveOuterQuotes function did not check the line length, resulting in the following error if an empty line is present: string index out of range The function now only checks string that are at least 2 char long * Fixup crash when filefilter contains comments The _ProcessFilterLine function returned None when a comment was found instead of the filter. The caller replaces the filter with the function return value. The next call then crashed with the following error: 'NoneType' object has no attribute 'AddCppChecker' The filter is now returned in this case as well * Add an application test This new test runs the app as the user would with a bit of configuration * Review: invert GetCliKeyValueMap condition * Review: rework test resources
- Loading branch information
Showing
5 changed files
with
29 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# This filefilter is here to ensure that the app: | ||
# - handles comments properly | ||
# - handles empty lines correctly | ||
|
||
~ RULE_3_1_A_do_not_start_filename_with_underbar | ||
~ RULE_3_3_A_start_function_name_with_lowercase_unix | ||
~ RULE_3_3_B_start_private_function_name_with_underbar | ||
~ RULE_4_5_B_use_braces_even_for_one_statement | ||
~ RULE_7_2_B_do_not_use_goto_statement | ||
~ RULE_9_1_A_do_not_use_hardcorded_include_path | ||
~ RULE_9_2_D_use_reentrant_function |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
int main(int argc, char* argv[]) | ||
{ | ||
return 1; | ||
} |