Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIデザイン使用性チェックリストをアップデート #1393

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

versionfive
Copy link
Contributor

@versionfive versionfive commented Nov 19, 2024

課題・背景

チェ活会KR2で整理した内容を踏まえてチェックリストを最新化したい

やったこと

  • 「達成基準」セクションを追加し、カテゴリごとの達成基準を追記
  • 「基準の充足状況」列を「達成基準」列に変更し、↑にリンク
  • チェック内容をアップデート(基準へのリンクを内容に含むようにした)
  • その他
    • HTMLタグで書いてた部分がマークダウンでかけるようになったので変更

やらなかったこと

  • チェック手順はレビューがきたら全体的にアップデートします
  • 情報設計のアウトプットもレビュードキュメントにぶら下げることを想定しているため、ここに含んでいません。

動作確認

キャプチャ

Before After

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit e196e88
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/673c6735195ad100096ed4a1
😎 Deploy Preview https://deploy-preview-1393--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@versionfive versionfive marked this pull request as ready for review November 22, 2024 03:14
Copy link
Contributor

@ysasaki10 ysasaki10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@oremega oremega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fujitha fujitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

Copy link
Contributor

@tosiiu tosiiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@versionfive versionfive merged commit 28b0f8a into main Nov 26, 2024
5 checks passed
@versionfive versionfive deleted the update-usability-checklist branch November 26, 2024 07:21
@versionfive versionfive restored the update-usability-checklist branch November 27, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants