Fix hit wrong many times bug

kubk · Nov 5, 2023 · f6735b2 · f6735b2
1 parent 6b3a813
commit f6735b2
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 1 deletion.
diff --git a/src/store/review-store.test.ts b/src/store/review-store.test.ts
@@ -179,4 +179,43 @@ describe("card form store", () => {
     expect(reviewStore.currentCard).toBeFalsy();
     expect(reviewStore.nextCard).toBeFalsy();
   });
+
+  it('hit wrong many times', () => {
+    const reviewStore = new ReviewStore();
+    reviewStore.startDeckReview(deckCardsMock);
+    expect(reviewStore.isFinished).toBeFalsy();
+
+    reviewStore.open()
+    reviewStore.changeState(CardState.Forget);
+
+    reviewStore.open()
+    reviewStore.changeState(CardState.Forget);
+
+    reviewStore.open()
+    reviewStore.changeState(CardState.Forget);
+
+    reviewStore.open()
+    reviewStore.changeState(CardState.Forget);
+
+    reviewStore.open()
+    reviewStore.changeState(CardState.Forget);
+
+    reviewStore.open()
+    reviewStore.changeState(CardState.Forget);
+
+    expect(reviewStore.result.forgotIds).toHaveLength(3)
+    expect(reviewStore.result.rememberIds).toHaveLength(0)
+
+    reviewStore.open()
+    reviewStore.changeState(CardState.Remember);
+
+    reviewStore.open()
+    reviewStore.changeState(CardState.Remember);
+
+    reviewStore.open()
+    reviewStore.changeState(CardState.Remember);
+
+    expect(reviewStore.result.forgotIds).toHaveLength(3)
+    expect(reviewStore.result.rememberIds).toHaveLength(0)
+  })
 });
diff --git a/src/store/review-store.ts b/src/store/review-store.ts
@@ -80,7 +80,9 @@ export class ReviewStore {
     assert(currentCardIdx !== -1);
     this.cardsToReview.splice(currentCardIdx, 1);
     if (currentCard.state === CardState.Forget) {
-      this.result.forgotIds.push(currentCard.id);
+      if (!this.result.forgotIds.includes(currentCard.id)) {
+        this.result.forgotIds.push(currentCard.id);
+      }
       currentCard.close();
       this.cardsToReview.push(currentCard);
     }