-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update persistent TPM & UEFI page to clarify storageclass requirements #830
base: main
Are you sure you want to change the base?
Conversation
Hi @ianb-mp. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I was unsure if the following statement is still true - can anyone confirm?
|
I think so - https://github.com/kubevirt/kubevirt/blob/effcb5b8e6fc951ec5c85ba47ad1daedc0173d79/pkg/virt-api/webhooks/validating-webhook/admitters/vmsnapshot-admitter.go#L166-L174 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
@akalenyu @victortoso @jean-edouard could someone please review? |
Thank you @ianb-mp for this update. It looks good but needs to be reworked a bit to reflect most recent changes. |
/approve |
Signed-off-by: Ian Bishop <[email protected]>
Signed-off-by: Ian Bishop <[email protected]>
b0f3bf4
to
45e5f6b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Update Persistent TPM and UEFI state to reflect the changes made in kubevirt/kubevirt#11773
Also, small spelling fix: prerequesites -> prerequisites(fixed in #846)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: