Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cnv:vmi_status_running:count #782

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Update cnv:vmi_status_running:count #782

merged 1 commit into from
Dec 22, 2023

Conversation

sradco
Copy link
Collaborator

@sradco sradco commented Dec 14, 2023 •
edited
Loading

What this PR does / why we need it:
Update cnv:vmi_status_running:count.
Added the labels instance_type and preference.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

The cnv:vmi_status_running:count recording rule is now also aggregated by the instance_type and preference labels.

@sradco
Update cnv:vmi_status_running:count
58f33d9 
Update cnv:vmi_status_running:count.
Added the labels instance_type and preference.

Signed-off-by: Shirly Radco <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 14, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

/cc sradco

@kubevirt-bot
Copy link
Contributor

@github-actions[bot]: GitHub didn't allow me to request PR reviews from the following users: sradco.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc sradco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 14, 2023
@sradco
Copy link
Collaborator Author

sradco commented Dec 14, 2023

@machadovilaca please review

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 14, 2023
@machadovilaca
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@sradco
Copy link
Collaborator Author

sradco commented Dec 14, 2023

Hi @0xFelix can you please review this PR?

0xFelix
0xFelix approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@sradco
Copy link
Collaborator Author

sradco commented Dec 14, 2023

/retest-required

@akrejcir
Copy link
Collaborator

CI is broken currently. All our PRs are failing.

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest-required

1 similar comment
@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest-required

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

2 similar comments
@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

@sradco
Copy link
Collaborator Author

sradco commented Dec 21, 2023

@0xFelix Hi, Am I missing an lgtm?

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

@sradco No, we're still having issues with CI.

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

1 similar comment
@0xFelix
Copy link
Member

0xFelix commented Dec 22, 2023

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 22, 2023

@sradco: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-functests 58f33d9 link true /test e2e-upgrade-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@0xFelix
Copy link
Member

0xFelix commented Dec 22, 2023

/override ci/prow/e2e-upgrade-functests

@kubevirt-bot
Copy link
Contributor

@0xFelix: Overrode contexts on behalf of 0xFelix: ci/prow/e2e-upgrade-functests

In response to this:

/override ci/prow/e2e-upgrade-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 89041d0 into kubevirt:main Dec 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@0xFelix 0xFelix

@machadovilaca machadovilaca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sradco @kubevirt-bot @machadovilaca @akrejcir @0xFelix