Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.18] Reduce VirtualMachineCRCErrors noise #690

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[release-v0.18] Reduce VirtualMachineCRCErrors noise #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/operands/metrics/resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,9 @@ func getAlertRules() ([]promv1.Rule, error) {
},
{
Alert: "VirtualMachineCRCErrors",
Expr: intstr.FromString("kubevirt_ssp_vm_rbd_volume{volume_mode=\"Block\", rxbounce_enabled=\"false\"} > 0"),
Expr: intstr.FromString("(count(kubevirt_ssp_vm_rbd_volume{volume_mode=\"Block\", rxbounce_enabled=\"false\"} > 0) or vector(0)) > 0"),
Annotations: map[string]string{
"description": "VirtualMachine {{ $labels.namespace }}/{{ $labels.name }} may report OSD errors",
"description": "{{ $value }} Virtual Machines are in risk of causing CRC errors and major service outages",
"summary": "When running VMs using ODF storage with 'rbd' mounter or 'rbd.csi.ceph.com provisioner', it will report bad crc/signature errors and cluster performance will be severely degraded if krbd:rxbounce is not set.",
"runbook_url": fmt.Sprintf(runbookURLTemplate, "VirtualMachineCRCErrors"),
},
Expand Down
2 changes: 1 addition & 1 deletion tests/monitoring_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ var _ = Describe("Prometheus Alerts", func() {
alertShouldNotBeActive("VirtualMachineCRCErrors")
})

It("[test_id:TODO] Should fire VirtualMachineCRCErrors is disabled", func() {
It("[test_id:TODO] Should fire VirtualMachineCRCErrors when rxbounce is disabled", func() {
vmName := createResources(true, false)
waitForSeriesToBeDetected(fmt.Sprintf("kubevirt_ssp_vm_rbd_volume{name='%s', rxbounce_enabled='false'}", vmName))
waitForAlertToActivate("VirtualMachineCRCErrors")
Expand Down
Loading