chore: Wrap some errors with more information

Added more context for errors in logs.

Signed-off-by: Andrej Krejcir <[email protected]>

controllers/setup.go

@@ -36,21 +36,21 @@ func CreateAndStartReconciler(ctx context.Context, mgr controllerruntime.Manager
 	mgrCtx = logr.NewContext(mgrCtx, mgr.GetLogger())
 
 	if err := setupManager(mgrCtx, cancel, mgr); err != nil {
-		return err
+		return fmt.Errorf("failed to setup manager: %w", err)
 	}
 
 	mgr.GetLogger().Info("starting manager")
 	if err := mgr.Start(mgrCtx); err != nil {
 		mgr.GetLogger().Error(err, "problem running manager")
-		return err
+		return fmt.Errorf("failed to start manager: %w", err)
 	}
 	return nil
 }
 
 func setupManager(ctx context.Context, cancel context.CancelFunc, mgr controllerruntime.Manager) error {
 	runningOnOpenShift, err := common.RunningOnOpenshift(ctx, mgr.GetAPIReader())
 	if err != nil {
-		return err
+		return fmt.Errorf("failed to check if running on openshift: %w", err)
 	}
 
 	templatesFile := filepath.Join(templateBundleDir, "common-templates-"+common_templates.Version+".yaml")
@@ -68,13 +68,13 @@ func setupManager(ctx context.Context, cancel context.CancelFunc, mgr controller
 	tektonPipelinesBundlePaths := tekton_bundle.GetTektonPipelineBundlePaths()
 	tektonPipelinesBundle, err := tekton_bundle.ReadBundle(tektonPipelinesBundlePaths)
 	if err != nil {
-		return err
+		return fmt.Errorf("failed to read tekton pipelines bundle: %w", err)
 	}
 
 	tektonTasksBundlePath := tekton_bundle.GetTektonTasksBundlePath(runningOnOpenShift)
 	tektonTasksBundle, err := tekton_bundle.ReadBundle([]string{tektonTasksBundlePath})
 	if err != nil {
-		return err
+		return fmt.Errorf("failed to read tekton tasks bundle: %w", err)
 	}
 
 	tektonPipelinesOperand := tekton_pipelines.New(tektonPipelinesBundle)
@@ -118,7 +118,7 @@ func setupManager(ctx context.Context, cancel context.CancelFunc, mgr controller
 	crdWatch.SomeCrdRemovedHandler = cancel
 
 	if err = crdWatch.Init(ctx, mgr.GetAPIReader()); err != nil {
-		return err
+		return fmt.Errorf("failed to initialize CRD watch: %w", err)
 	}
 
 	if missingCrds := crdWatch.MissingCrds(); len(missingCrds) > 0 {
@@ -131,12 +131,12 @@ func setupManager(ctx context.Context, cancel context.CancelFunc, mgr controller
 	if runningOnOpenShift {
 		infrastructureTopology, err = common.GetInfrastructureTopology(ctx, mgr.GetAPIReader())
 		if err != nil {
-			return err
+			return fmt.Errorf("failed to get infrastructure topology: %w", err)
 		}
 	}
 
 	if err = mgr.Add(crdWatch); err != nil {
-		return err
+		return fmt.Errorf("failed to add CRD watch to manager: %w", err)
 	}
 
 	serviceController, err := CreateServiceController(ctx, mgr)

internal/crd-watch/crd-watch.go

@@ -116,11 +116,11 @@ func (c *CrdWatch) Start(ctx context.Context) error {
 		},
 	})
 	if err != nil {
-		return err
+		return fmt.Errorf("failed to add event handler to informer: %w", err)
 	}
 
 	if err := c.sync(ctx, c.cache); err != nil {
-		return err
+		return fmt.Errorf("failed to sync CRD watch: %w", err)
 	}
 
 	// This function has to block, because that is what manager.Runnable expects.