needs-approver-review: enable management by GH team #3770
Conversation
Currently the only user who can apply or remove the label `needs-approver-review` is the `kubevirt-bot` user. This change introduces a new GitHub team under the KubeVirt org that contains the people who will be allowed to apply or remove the label - changing the orgs.yaml to achieve this. Then the `label` config is extended to allow above created group to manage the label - changing plugins.yaml. Signed-off-by: Daniel Hiller <[email protected]>
kubevirt-bot
requested review from
aburdenthehand,
alicefr,
iholder101 and
vladikr
kubevirt-bot
added
dco-signoff: yes
|
/override pull-kubevirt-org-github-config-updater since it complains about a team not existing that we want to create |
|
@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-org-github-config-updater In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| needs-approver-review-label: | ||
| description: "Users who can manage needs-approver-review label to any PR inside the KubeVirt org" |
There was a problem hiding this comment.
Does it make sense to add the needs-approver-review-label label to the kubevirtkubevirt-label group below instead of creating a new one?
There was a problem hiding this comment.
I don't think so, since this group can change the label in every repo, whereas the other group can only change labels inside k/kubevirt.
There was a problem hiding this comment.
Is there a reason for it though?
Why wouldn't members be able to add the good-first-issue to every repo?
There was a problem hiding this comment.
In any case, it shouldn't block this PR, just an idea.
/lgtm
There was a problem hiding this comment.
Is there a reason for it though? Why wouldn't members be able to add the
good-first-issueto every repo?
Because at the time there was opinions about how and when to apply the labels good-first-issue and help-wanted and who could apply them.
I.e. for project-infra it works through the prow help plugin - anyone can just write /help-wanted or /good-first-issue and the labels will get applied. In contrast to this in k/kubevirt the consensus was that only a dedicated group of people should apply labels (that's also the reason why there's two good-first-issue labels (https://github.com/kubevirt/project-infra/blob/main/docs/labels.md#good%20first%20issue).
As much as I had wanted to align people over just using the prow help plugin and not having to maintain an extra configuration for labels, we didn't agree on this - and I respect that decision.
There was a problem hiding this comment.
Example issue for k/project-infra: #3768 (comment)
(reaction by plugin can be seen in follow up)
There was a problem hiding this comment.
Forgot one thing: the help plugin has the drawback that everyone who comments on a PR can apply the label - I think the label should only get applied if an org member does comment, however I don't know that for sure and would need to check.
There was a problem hiding this comment.
I just checked - the plugin reacts to any comment, so in essence anyone with a GitHub account can trigger help, however I think the cost of unjustified application of a label is neglectible to the cost of having to maintain the configuration, but that's just my opinion.
|
/lgtm |
|
@brianmcarey FYI - if you have the time 🙏 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/override pull-kubevirt-org-github-config-updater since that check is complaining about a team which we want to create... |
|
@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-org-github-config-updater In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dhiller: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Currently the only user who can apply or remove the label
needs-approver-reviewis thekubevirt-botuser.This change introduces a new GitHub team under the KubeVirt org that contains the people who will be allowed to apply or remove the label - changing the orgs.yaml to achieve this.
Then the
labelconfig is extended to allow above created group to manage the label - changing plugins.yaml.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @vladikr @iholder101 @alicefr @aburdenthehand