chore: insert OwnerReferences param to pipelines #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
sometimes the pipeline can fail and cleanup tasks are not triggered. By inserting the ownerReferences to created objects, when the pipelineRun fails, they can still be deleted by deleting the pipelineRun Signed-off-by: Karel Simon <[email protected]>
ksimon1
force-pushed
the
pipelines-references
branch
from
e0e1645 to
85c00a5
Compare
|
/lgtm |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
chore: insert OwnerReferences param to pipelines
sometimes the pipeline can fail and cleanup tasks are not triggered. By inserting the ownerReferences to created objects, when the pipelineRun fails, they can still be deleted by deleting the pipelineRun
Release note: