chore: unify disk-virt task code #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
|
/hold cancel |
|
/retest |
ksimon1
changed the title
kubevirt-bot
removed
the
do-not-merge/work-in-progress
0xFelix
reviewed
Jul 10, 2024
| @@ -33,10 +33,10 @@ spec: | |||
| params: | |||
| - name: pvc | |||
| value: "$(tasks.modify-data-object.results.name)" | |||
| - name: sysprepCommands | |||
There was a problem hiding this comment.
Does this change user facing parameters?
ksimon1
force-pushed
the
unify-dks-virt-code
branch
from
31cd685 to
e585720
Compare
|
/retest |
1 similar comment
|
/retest |
The disk-virt tasks have almost identical code. This commit keeps only single version of disk-virt code. The params of the tasks were unified and renamed: customizeCommands, sysprepCommands -> virtCommands additionalOptions -> additionalVirtOptions Signed-off-by: Karel Simon <[email protected]>
ksimon1
force-pushed
the
unify-dks-virt-code
branch
from
e585720 to
adcddc7
Compare
0xFelix
approved these changes
Jul 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix, ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It will be mentioned as a breaking change in release, then the new params will be part of README of each task |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
chore: unify disk-virt task code
The disk-virt tasks have almost identical code. This commit keeps only single version of disk-virt code.
Special notes for your reviewer:
Release note: