fix: allowReplace param for datasource in modify-data-object task #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/retest |
when datasource does not exists and allowReplace param is set to true, the task fails, because it could not find the object. This commit adds check if the error returned is notFound and if yes, do not return the error Signed-off-by: Karel Simon <[email protected]>
ksimon1
force-pushed
the
fix-allow-replace-datasource
branch
from
fb206c1 to
eb87194
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
/cherrypick release-v0.17 |
|
@ksimon1: new pull request created: #432 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix: allowReplace param for datasource in modify-data-object task
when datasource does not exists and allowReplace param is set to true, the task fails, because it could not find the object. This commit adds check if the error returned is notFound and if yes, do not return the error
Release note: