chore: deploy configmaps as a part of pipeline #375
Conversation
kubevirt-bot
added
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
|
/cc @dominikholler |
|
/retest |
kubevirt-bot
added
the
needs-rebase
kubevirt-bot
removed
the
needs-rebase
ksimon1
force-pushed
the
apply-configmaps
branch
2 times, most recently
from
f8e1986 to
53844de
Compare
kubevirt-bot
added
the
needs-rebase
kubevirt-bot
removed
the
needs-rebase
|
/retest |
release/pipelines/windows-efi-installer/windows-efi-installer.yaml
Outdated
Show resolved
Hide resolved
release/pipelines/windows-efi-installer/windows-efi-installer.yaml
Outdated
Show resolved
Hide resolved
kubevirt-bot
added
the
needs-rebase
kubevirt-bot
removed
the
needs-rebase
ksimon1
changed the title
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
release/pipelines/windows-efi-installer/windows-efi-installer.yaml
Outdated
Show resolved
Hide resolved
| - name: delete-imported-configmaps | ||
| params: | ||
| - name: SCRIPT | ||
| value: oc delete -f $(params.autounattendXMLConfigMapsURL) |
There was a problem hiding this comment.
Can we cache the config map somewhere? If it changes during the pipeline run, then the delete might not work as expected.
There was a problem hiding this comment.
we can use the customizeConfigMapName or autounattendConfigMapName params to delete the correct configmaps instead of URL
There was a problem hiding this comment.
Problem will be, if the URL contains multiple configmaps, then it will delete only single CM
There was a problem hiding this comment.
Can you return the created config maps as a result in import-unattend-configmaps and use that result to delete them in delete-imported-configmaps?
There was a problem hiding this comment.
I don't think so, because the task does not have results defined in manifest https://github.com/tektoncd/catalog/blob/main/task/openshift-client/0.2/openshift-client.yaml#L14
There was a problem hiding this comment.
Can you perhaps cache the ConfigMaps file in a Workspace instead?
There was a problem hiding this comment.
If I am not mistaken, the workspaces requires record in PipelinerRun (see the note in https://tekton.dev/docs/pipelines/workspaces/#specifying-workspaces-in-pipelineruns). That means, we would break triggering of the pipeline from the UI. Users would have to build their own manifest for triggering the pipeline, which would go against the idea of this pipeline.
There was a problem hiding this comment.
Unfortunate. I'm just concerned this will be handed back to us as a possible bug in the future. If there's not other way, maybe we can at least document it in the description or somewhere?
There was a problem hiding this comment.
fair point, let me update it tomorrow
this change will remove the step, when user has to manually create the necessary ConfigMaps needed by VM. They are now deployed and removed by the Pipeline. Added new parameter acceptEula - By setting this parameter to true, user is accepting Eula specified in autounattend.xml file in ConfigMap. If param is set to false, pipeline will exit immediatelly Signed-off-by: Karel Simon <[email protected]>
during the Pipeline run The contents of autounattendXMLConfigMapsURL may change during the Pipeline run. This commit documents that if this happens, Pipeline may not be able to remove all deployed ConfigMaps. Signed-off-by: Karel Simon <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix, ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
What this PR does / why we need it:
chore: deploy configmaps as a part of pipeline
this change will remove the step, when user has to manually create the necessary ConfigMaps needed by VM. They are now deployed and removed by the Pipeline.
Added new parameter acceptEula - By setting this parameter, user is agreeing to the applicable Microsoft end user license agreement(s) for each deployment or installation for the Microsoft product(s). If param is set to false, or empty, pipeline will exit immediatelly
Release note: