Skip to content

Commit

Permalink
feat: remove cluster wide permission objects
Browse files Browse the repository at this point in the history
Kubevirt-tekton-tasks does not need to ship additional
service accounts, role bindings and cluster roles, because
if no service account is provided, tekton uses default SA
pipeline, which is available in almost all namespaces and already
has all necessary permission. This change will allow non
privilidged user to run tasks without need admin permissions.
The permission objects will remain only in README of each task
so user can easily make it work if user will need multinamespace
functionality.

This PR adjusts testing framework + all affected scripts
Signed-off-by: Karel Simon <[email protected]>
  • Loading branch information
ksimon1 committed Feb 7, 2024
1 parent 20707a7 commit ee0dfaa
Show file tree
Hide file tree
Showing 95 changed files with 1,119 additions and 2,232 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/test-yaml-consistency.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: test yaml consistency

on:
pull_request:
branches: [ main ]

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: test yaml consistency
run: scripts/test-yaml-consistency.sh
3 changes: 2 additions & 1 deletion automation/e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ export NUM_NODES=${NUM_NODES:-2}

./automation/e2e-deploy-resources.sh

kubectl get namespaces -o name | grep -Eq "^namespace/$DEPLOY_NAMESPACE$" || kubectl create namespace "$DEPLOY_NAMESPACE"
oc get namespaces -o name | grep -Eq "^namespace/$DEPLOY_NAMESPACE$" || oc create namespace "$DEPLOY_NAMESPACE"
oc project "$DEPLOY_NAMESPACE"

if [[ "$DEV_MODE" == "true" ]]; then
make cluster-sync
Expand Down
263 changes: 0 additions & 263 deletions manifests/kubernetes/kubevirt-tekton-tasks-kubernetes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit ee0dfaa

Please sign in to comment.