fix(CNV-52011): generate random VMExport secret name

When running disk-uploader it creates VMExport secret to store a token that required by the Export API endpoints. Currently the name of VMExport secret is not random generated and will fail to be created again if the disk-uploader (as a Tekton Task) will run twice. As a result, it throws a panic error that causes the failure of the execution. Signed-off-by: Ben Oukhanov <[email protected]>
kubevirt · Nov 27, 2024 · 9b539e1 · 9b539e1
1 parent 796c31b
commit 9b539e1
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/modules/disk-uploader/pkg/secrets/secrets.go b/modules/disk-uploader/pkg/secrets/secrets.go
@@ -5,11 +5,13 @@ import (
 	"crypto/rand"
 	"fmt"
 	"math/big"
+	"strings"
 
 	"github.com/kubevirt/kubevirt-tekton-tasks/modules/shared/pkg/ownerreference"
 
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	k8srand "k8s.io/apimachinery/pkg/util/rand"
 	"k8s.io/client-go/kubernetes"
 )
 
@@ -22,7 +24,7 @@ func CreateVirtualMachineExportSecret(k8sClient kubernetes.Interface, namespace,
 
 	v1Secret := &corev1.Secret{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      name,
+			Name:      generateName(name),
 			Namespace: namespace,
 		},
 		StringData: map[string]string{
@@ -66,3 +68,8 @@ func generateSecureRandomString(n int) (string, error) {
 
 	return string(ret), nil
 }
+
+func generateName(name string) string {
+	id := k8srand.String(5)
+	return strings.Join([]string{name, id}, "-")
+}